helm: only use Digest to calculcate index revision #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
hiddeco
added
bug
hiddeco
force-pushed
the
helm-index-digest-rev
branch
from
03300fd to
5f2bcfc
Compare
In #1001 bits around the Helm repository reconciliation logic were rewritten, mostly based on the documented behavior instead of the actual code. This resulted in the reintroduction of a YAML marshal of the (sorted) index YAML instead of reliance of just the checksum of the file. This to take situations into account in which a repository would e.g. provide a new random order on every generation. However, this approach is (extremely) expensive as the marshal goes through a JSON -> YAML loop, eating lots of RAM in the process. As the further (silently) introduced behavior has not resulted in any reported issues, I deem this approach safe and better than e.g. encoding to just JSON which would still require a substantial amount of memory. Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
helm-index-digest-rev
branch
from
5f2bcfc to
c712fed
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release candidate:
ghcr.io/fluxcd/source-controller:rc-e5c0313dIn #1001 bits around the Helm repository reconciliation logic were rewritten, mostly based
on the documented behavior instead of the actual code. This resulted in the reintroduction
of a YAML marshal of the (sorted) index YAML instead of reliance of just the checksum of
the file.
This to take situations into account in which a repository would e.g. provide a new
random order on every generation. However, this approach is (extremely) expensive as
the encoder goes through a JSON -> YAML loop, eating lots of RAM in the process.
As the further (silently) introduced behavior has not resulted in any reported issues, I deem
this approach safe and better than e.g. encoding to just JSON which would still require a
substantial amount of memory.
Fixes fluxcd/flux2#3620