Move controllers to internal/controller #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
internal-controller
branch
from
ea3900d to
2dce756
Compare
|
In all other projects we kept the naming |
|
@stefanprodan this is what upstream did when they moved to internal, we somehow missed this when quickly moving everything. |
stefanprodan
approved these changes
May 2, 2023
hiddeco
approved these changes
May 2, 2023
Make the controller implementations private. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
internal-controller
branch
from
2dce756 to
e16d6eb
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the controller implementations private.
closes fluxcd/flux2#3719 .