Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

storage: set 0o744 for files with exec mode set #1094

Merged
merged 1 commit into from
May 12, 2023

Conversation

rashedkvm
Copy link
Member

@rashedkvm rashedkvm commented May 11, 2023

This PR ensures that files with exec permissions set continue to be
executable by the user extracting the archive.

This is not of use to any of Flux itself, but does help downstream
dependents making use of the controller to facilitate artifact
acquisitions for their (CI/CD) software suite.

Fixes #1090

@rashedkvm rashedkvm force-pushed the executable-permission branch from 5f15e19 to 790ea76 Compare May 11, 2023 22:50
@rashedkvm rashedkvm requested review from hiddeco and makkes May 11, 2023 22:51
@rashedkvm rashedkvm force-pushed the executable-permission branch from 790ea76 to 49f731b Compare May 11, 2023 23:20
internal/controller/storage.go Outdated Show resolved Hide resolved
internal/controller/storage.go Outdated Show resolved Hide resolved
internal/controller/storage.go Outdated Show resolved Hide resolved
@hiddeco hiddeco force-pushed the executable-permission branch 2 times, most recently from 67aa1a5 to a56bd6a Compare May 12, 2023 08:01
@hiddeco hiddeco changed the title fix:Set default permission in artifact archive executable files storage: set 0o744 for files with exec mode set May 12, 2023
@hiddeco hiddeco added enhancement New feature or request area/storage Storage related issues and pull requests labels May 12, 2023
@hiddeco hiddeco force-pushed the executable-permission branch from a56bd6a to dc3482d Compare May 12, 2023 08:04
This commit ensures that files with exec permissions set continue to be
executable by the user extracting the archive.

This is not of use to any of Flux itself, but does help downstream
dependents making use of the controller to facilitate artifact
acquisitions for their (CI/CD) software suite.

Co-authored-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Rashed Kamal <krashed@vmware.com>
@hiddeco hiddeco force-pushed the executable-permission branch from dc3482d to 2736b74 Compare May 12, 2023 08:11
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco merged commit fcc6ec3 into fluxcd:main May 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/storage Storage related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source filesystem execute permission is being overwritten in the artifact archive
3 participants