Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix link ref in API docs #1204

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix link ref in API docs #1204

merged 1 commit into from
Aug 23, 2023

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Aug 22, 2023 •
edited
Loading

Follow up: #1200

@somtochiama somtochiama added the area/docs Documentation related issues and pull requests label Aug 22, 2023
@makkes makkes added the backport:release/v1.0.x To be backported to release/v1.0.x label Aug 22, 2023
kingdonb
kingdonb approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@kingdonb kingdonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kingdonb
Copy link
Member

So now, we don't do anything to #1205 right - this will simply get backported by the bot like every other PR?

Sorry for this error, it's a lot of stitching things together to see if you have really fixed the issue each time you fix one of these!

@somtochiama
fix link
47ff472 
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan merged commit 052221c into fluxcd:main Aug 23, 2023
@fluxcdbot fluxcdbot mentioned this pull request Aug 23, 2023
Merged
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v1.0.x:

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@makkes makkes makkes approved these changes

@kingdonb kingdonb kingdonb approved these changes

@stefanprodan stefanprodan Awaiting requested review from stefanprodan

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests backport:release/v1.0.x To be backported to release/v1.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@somtochiama @kingdonb @fluxcdbot @makkes @stefanprodan