Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Address miscellaneous issues throughout code base #1257

Merged
merged 17 commits into from
Oct 11, 2023
Merged

Address miscellaneous issues throughout code base #1257

merged 17 commits into from
Oct 11, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Oct 9, 2023

No description provided.

hiddeco added 6 commits October 9, 2023 14:59
@hiddeco
misc: use Err prefix for errors
354a8e8 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: remove redundant return statements
25400d8 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: remove unnecessary use of fmt.Sprintf
8d1c755 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: properly handle f.Close() defer
0288645 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: ensure return errs are captured
691d925 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: simplify by directly returning bool
3a0c279 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
stefanprodan
stefanprodan approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco 🏅

@hiddeco
misc: address k8s.io/utils/pointer deprecation
d56d0a7 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: iotuil deprecation
0a27f6a 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: rand.Seed deprecation
d9dbd1b 
See: https://pkg.go.dev/math/rand@go1.20#Seed

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
darkowlzz
darkowlzz approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about a deprecated API usage.
Other than that, the changes LGTM!

pkg/azure/blob_integration_test.go Show resolved Hide resolved
@hiddeco
misc: math/rand.Read() has been deprecated
a74eb57 
See: https://pkg.go.dev/math/rand@go1.20#Read

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: address duplicate imports
2023081 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: add test case for invalid tag signature
cdb43f1 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: remove unused code
a70b3f3 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: remove redundant nil check
aba9800 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: do not capitalize err string and fix wording
b0d94ce 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: fix hypothetical implicit memory aliasing
04612b5 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
misc: set TLS certificate files perms to 0o600
09772bd 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco merged commit fe1173f into main Oct 11, 2023
@hiddeco hiddeco deleted the tidy-nits branch October 11, 2023 09:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiddeco @darkowlzz @stefanprodan