helmrepo: Remove migration log/event #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be logged/event emitted forever once in the lifecycle of HelmRepository OCI object because all new objects have to remove the .status.observedGeneration which is set to -1 by the API defaulting. Better to perform the object conversion internally without any log or event. Signed-off-by: Sunny <darkowlzz@protonmail.com>
stefanprodan
added
the
backport:release/v1.2.x
19 tasks
|
Successfully created backport PR for |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be logged/event emitted forever once in the lifecycle of HelmRepository OCI object because all new objects have to remove the
.status.observedGenerationwhich is set to -1 by the API defaults. Better to perform the object conversion internally without any log or event.