-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for .spec.proxySecretRef
for generic provider of Bucket API
#1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67343c2
to
585626e
Compare
3d7db8a
to
da66e44
Compare
9f00810
to
02fea49
Compare
02fea49
to
99c3701
Compare
99c3701
to
c591823
Compare
c591823
to
af1652b
Compare
5de61f0
to
ce93f13
Compare
95ee307
to
11893b4
Compare
darkowlzz
reviewed
Jun 25, 2024
darkowlzz
reviewed
Jun 25, 2024
darkowlzz
reviewed
Jun 25, 2024
ea7b75f
to
540e38c
Compare
3eba1e2
to
6f546d9
Compare
darkowlzz
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks.
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
6f546d9
to
4d9c87c
Compare
stefanprodan
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @matheuscscp 🏅
.spec.proxySecretRef
for generic provider of Bucket API
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1493