Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enable self-signed certs for go-git #324

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Enable self-signed certs for go-git #324

merged 1 commit into from
Mar 29, 2021

Conversation

stefanprodan
Copy link
Member

Changes:

  • Update go-git to v5.3.0
  • Set CABundle to go-git checkout if found in secret
  • Add go-git tests for self-signed certs
  • Update self-signed certs docs

PS. With this change we can now add --ca-file to bootstrap and allow people to use self-signed certs for GitHub/GitLab on-prem (see fluxcd/flux2#1167)

@stefanprodan
Enable self-signed certs for go-git
f0016cf 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added enhancement New feature or request area/git Git related issues and pull requests labels Mar 29, 2021
@stefanprodan stefanprodan requested a review from hiddeco March 29, 2021 10:28
hiddeco
hiddeco approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM @stefanprodan 🥇

@stefanprodan stefanprodan merged commit 3600fe3 into main Mar 29, 2021
@stefanprodan stefanprodan deleted the go-git-cabundle branch March 29, 2021 11:39
@kingdonb kingdonb mentioned this pull request Feb 11, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/git Git related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco