Fix pointer error during public key import #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A reference back to the Slack thread where this issue was revealed: |
hiddeco
approved these changes
Oct 29, 2021
hiddeco
added
area/git
hiddeco
reviewed
Oct 29, 2021
For signed commit verification, this code errors out on line 303: ✗ GitRepository reconciliation failed: ''PGP public keys secret error: expected pointer, but got nil Pointer was not initialized with a concrete instance of the Secret struct Signed-off-by: Kingdon Barrett <yebyen@gmail.com>
kingdonb
force-pushed
the
fix-commit-verification
branch
from
1797b3c to
d400c8e
Compare
|
I updated the PR per your suggestion @hiddeco thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the signed commit verification feature that is documented, we noticed this code errors out on line 303:
Looks like the pointer was not initialized with a concrete instance of the Secret struct, so this code fails.
I have manually verified this change enables commit verification, and that unsigned commits (or missing pgp keys) fail in expected ways now:
or
(both of these are expected failures)
We suspect that changes in controller-runtime are the culprit, this must have worked at the time it was added. (Might be good to cover it with a test, if it turns out we don't have one!)
Thanks to @citadelcore for bringing this to my attention!