-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Statically build using musl toolchain and target alpine #558
Conversation
@pjbgf I'm not for changing the runtime image in this release. Users will not be able to debug SC nor IAC if we use distroless since there is no shell so they can't see if tmp gets filled, or test egress or list artifacts. Please use Alpine or Bookwarm. |
➕ around Stefan's concerns, but no specific preference for an alternative image. |
@stefanprodan fair point - I will stick to Alpine as it is less than 10% of the size of bookworm-slim. |
315ff77
to
28365b5
Compare
79d81f1
to
040122a
Compare
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
040122a
to
d163eba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @pjbgf 🏅
Main changes:
alpine
as final base image.Although the controller is statically built, we are targeting
alpine
to help users debugging the image if they so need/wish.