Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

remove hostname hyphen split block #672

Merged
merged 1 commit into from
Apr 14, 2022
Merged

remove hostname hyphen split block #672

merged 1 commit into from
Apr 14, 2022

Conversation

EdwinWalela
Copy link
Contributor

This seeks to close #670.
Signed-off-by: edwinwalela edwinwalela@gmail.com

@EdwinWalela
remove hostname hyphen split block
9c4dfc0 
Signed-off-by: edwinwalela <edwinwalela@gmail.com>
hiddeco
hiddeco approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this long due bit @EdwinWalela 🙇

pjbgf
pjbgf approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwinWalela thank you for working on this. 🙇

@pjbgf pjbgf merged commit 2f4a337 into fluxcd:main Apr 14, 2022
@pjbgf pjbgf mentioned this pull request Apr 14, 2022
Closed
@EdwinWalela
Copy link
Contributor Author

@pjbgf Thanks for the help :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

@pjbgf pjbgf pjbgf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Maintainers' Focus
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdwinWalela @pjbgf @hiddeco