api: add custom validation for v1.Duration types #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To solve discrepancies between parsing versus validation. xref: kubernetes/apimachinery#131 Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
commented
Sep 20, 2022
| // +required | ||
| Interval metav1.Duration `json:"interval"` | ||
|
|
||
| // Timeout for fetch operations, defaults to 60s. | ||
| // +kubebuilder:default="60s" | ||
| // +kubebuilder:validation:Type=string | ||
| // +kubebuilder:validation:Pattern="^([0-9]+(\\.[0-9]+)?(ms|s|m))+$" |
There was a problem hiding this comment.
Did not include h for timeouts (nor did I include ns, us, µs) to stimulate the user to keep their bounds realistic.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve discrepancies between parsing versus validation.
xref: kubernetes/apimachinery#131