Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix aliased chart dependencies resolution #988

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

souleb
Copy link
Member

@souleb souleb commented Dec 16, 2022

If implemented, this fix the issue were aliased chart dependencies were detected but not included in the final packaged chart.

Fix: fluxcd/helm-controller#575
Signed-off-by: Soule BA soule@weave.works

@souleb souleb added bug Something isn't working area/helm Helm related issues and pull requests labels Dec 16, 2022
@souleb souleb force-pushed the fix-aliased-deps-resolution branch from 3cddf9b to 86eb62a Compare December 16, 2022 21:29
If implemented, this fix the issue were aliased chart dependencies were
detected but not included in the final packaged chart.

Signed-off-by: Soule BA <soule@weave.works>
@souleb souleb force-pushed the fix-aliased-deps-resolution branch from 86eb62a to 6b5d0b1 Compare December 16, 2022 22:12
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for picking this up @souleb 🙇

@souleb souleb merged commit 0f7a263 into fluxcd:main Dec 19, 2022
@souleb souleb deleted the fix-aliased-deps-resolution branch December 19, 2022 09:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/helm Helm related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm-Controller fails to render all Chart dependencies when using aliases
2 participants