feat(a32nx): hook up engine oil sim #9795
Conversation
| const double oilTemperaturePre = simData.engineOilTemperature[engineIdx]->get(); | ||
| const double oilTemperatureMax = MAX_OIL_TEMP_NOMINAL + (engineIdx + 1) == engineImbalanced ? imbalanceExtractor(imbalance, 8) : 0; | ||
| double oilTemperature; | ||
| if (isOnGround && engineState == EngineState::OFF && ambientTemp > oilTemperaturePre - 10) { |
There was a problem hiding this comment.
This also doesn't really make sense to me. It shouldn't really matter whether the plane is on the ground or not?
There was a problem hiding this comment.
I wasn't really looking to work on the code any further than needed, only re-enable it, but it ended up needing a bit of work due to changes in the FADEC code 😬 . I think this does make some sense as a sanity check for spawn situations where the Lvar might have an old value.
Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>
At least all the pieces are there which lowers the barrier to work on it a bit. Now it's just a matter of changing 1-2 lines rather than 50. |
Fixes #[issue_no]
Summary of Changes
Hook up the engine oil quantity and pressure code in the FADEC and into the SD.
The oil temp code doesn't make sense, so don't use it for now.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Try from cold and dark, through to airborne, with the ENG page open on the SD watching the oil pressure and quantity; ensure it is always reasonable.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.