Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ExternalScriptLoader is never used #283

Closed
frontant opened this issue Jul 30, 2020 · 1 comment · Fixed by #290
Closed

ExternalScriptLoader is never used #283

frontant opened this issue Jul 30, 2020 · 1 comment · Fixed by #290
Assignees
@domtra

Comments

@frontant
Copy link

Hello,
I just inspected the code in assets/scripts/ExternalScriptLoader and it seems to be used nowhere. Is it a bug?
@domtra
Copy link
Member

domtra commented Aug 6, 2020

Hi @frontant ,

this is not a bug. We used this in the past and still sometimes use it in projects.

However, this function is not used in flynt currently, so we will probably get rid in the future.

Thanks for pointing this out!

@domtra domtra closed this as completed Aug 6, 2020
domtra added a commit that referenced this issue Aug 12, 2020
@domtra
feat(ExternalScriptLoader): remove
50068d9 
closes #283
@domtra domtra mentioned this issue Aug 12, 2020
Merged
domtra added a commit that referenced this issue Aug 13, 2020
@domtra
feat(ExternalScriptLoader): remove
8c54251 
closes #283
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@domtra domtra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ExternalScriptLoader): remove flyntwp/flynt
2 participants
@domtra @frontant