Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Remove default config #478

Merged
merged 11 commits into from
Sep 27, 2022
Merged

Remove default config #478

merged 11 commits into from
Sep 27, 2022

Conversation

wild-endeavor
Copy link
Contributor

TL;DR

Removing unnecessary configuration.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Just clean up.

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #478 (9590c9a) into master (f0e4c89) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   61.67%   61.67%           
=======================================
  Files         158      158           
  Lines       11293    11293           
=======================================
  Hits         6965     6965           
  Misses       3609     3609           
  Partials      719      719           
Flag Coverage Δ
unittests 60.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
auth/config/config.go 71.42% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
erge branch 'update-default-config' of github.com:flyteorg/flyteadmin into update-default-config
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
EngHabu
EngHabu previously approved these changes Sep 27, 2022
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor wild-endeavor merged commit 281172e into master Sep 27, 2022
@wild-endeavor wild-endeavor deleted the update-default-config branch September 27, 2022 21:07
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants