Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Fix flyteadmin port in flytectl config init #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Mar 15, 2023

TL;DR

Fix the flyteadmin port by flytectl config init to match the one required by demo cluster

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

The flyteadmin port used in the demo cluster is 30080, so users who have rely on flytectl config init to generate a valid config file should be left with a config file that reflects that.

Tracking Issue

flyteorg/flyte#3461

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #400 (0bad2b7) into master (29da288) will increase coverage by 0.77%.
The diff coverage is 100.00%.

❗ Current head 0bad2b7 differs from pull request most recent head a295bf8. Consider uploading reports for the commit a295bf8 to get more accurate results

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   66.57%   67.35%   +0.77%     
==========================================
  Files         145      145              
  Lines        6271     5235    -1036     
==========================================
- Hits         4175     3526     -649     
+ Misses       1816     1429     -387     
  Partials      280      280              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/configuration/configuration.go 78.33% <100.00%> (+1.70%) ⬆️

... and 133 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants