Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(charts/paperless-ngx): use subPath for volumeMounts #22

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

fty4
Copy link
Contributor

@fty4 fty4 commented Sep 24, 2024

What this PR does / why we need it

Currently the same volume will be mounted on two paths - it might be better to use subPath to create a directory for each mount.
If no subPath is used both mounts will result in the same directory in the pod and share the files.

Checklist

  • Chart Version bumped
  • User name added to AUTHORS file
  • Title of the PR starts with a valid commit scope as detailed in the CONTRIBUTING (e.g.
    fix(charts/linkwarden): ...)

If no subPath is used both mounts will result in the same directory in the pod.
@fty4 fty4 requested a review from mvprowess as a code owner September 24, 2024 19:18
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 25, 2024
@fty4
Copy link
Contributor Author

fty4 commented Nov 4, 2024

Please do not close PR - still valid.

@github-actions github-actions bot removed the stale label Nov 4, 2024
mvprowess added a commit that referenced this pull request Nov 13, 2024
This commit updates a ton of files which mainly had an ending line appended.
In addition to that I fixed various typos and reformatted the 'values.yaml' files in
accordance 'ct' to make it stop complaining like alluded to in #22. Lastly obsolete
empty files have been removed.
@fty4
Copy link
Contributor Author

fty4 commented Nov 14, 2024

Bumped the chart and got expected workflow error for port (#21 (comment))

@mvprowess
Copy link
Contributor

Yeah, as expected.. I'll fix it on the weekend. Thanks again for your work, using my charts in general and the kind words on the last PR 😄 💯 Merging 👍🏼

@mvprowess mvprowess merged commit 87e17fd into fmjstudios:main Nov 14, 2024
4 of 5 checks passed
@fty4 fty4 deleted the fix/volume-subpath branch November 15, 2024 19:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants