suffixes for helper chrono types added in C++ 20 #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Oct 7, 2023
There was a problem hiding this comment.
Thanks for the PR but except for d I don't see these suffixes defined in https://eel.is/c++draft/time.duration.io.
vitaut
reviewed
Oct 7, 2023
vitaut
reviewed
Oct 7, 2023
vitaut
approved these changes
Oct 7, 2023
|
Thank you! |
ckerr
pushed a commit
to transmission/fmt
that referenced
this pull request
Nov 7, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ 20 added
std::chrono::daysstd::chrono::weeksstd::chrono::monthsstd::chrono::yearsThis adds suffixes for them.
The standard only specifies
dfor days, but it also specifiesminfor minutes, while fmt usesmso I am not sure how far you want to deviate from there.