Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use a named initializer in Engine #261

Merged
merged 2 commits into from
Oct 17, 2014
Merged

Conversation

timoschilling
Copy link

No description provided.

@PikachuEXE
Copy link

Any reason for that change?

@timoschilling
Copy link
Author

I want to place a initializer after the i18n-js one, but that only works if I can address them with the after attribute. I want do the same that i18n-js initializer do with the sprockets initializer.

@PikachuEXE
Copy link

Sure!
Can you please add a CHANGELOG entry and add a small section in README before I merge?

@timoschilling
Copy link
Author

The CHANGELOG entry is done.

But do we really need a README entry for that? I think who want to hook bevor or after that initializer, takes a look into the engine to see whats happen there.

@PikachuEXE
Copy link

Sure :P

PikachuEXE added a commit that referenced this pull request Oct 17, 2014
use a named initializer in Engine
@PikachuEXE PikachuEXE merged commit 52a66f8 into fnando:master Oct 17, 2014
@PikachuEXE
Copy link

I will release a new RC version next week, too long since last one

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants