Pass options object to nullPlaceholder and missingPlaceholder #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
added 3 commits
December 22, 2015 00:07
This allows arbitrary debugging data provided to I18n.translate to be used in an overridden I18n.missingPlaceholder method.
|
Sure thing. I've added a spec and CHANGELOG entry on this branch. |
|
Thanks! |
PikachuEXE
added a commit
that referenced
this pull request
Dec 22, 2015
…r-functions Pass options object to nullPlaceholder and missingPlaceholder
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I18n.missingPlaceholderexists so that it can be overridden for debugging purposes (#169). That's why it's passedmessage, even though the default implementation doesn't use it. This PR goes a small step further by also passingoptionsto that function. This allows you to pass arbitrary debugging information throughI18n.translatetoI18n.missingPlaceholder, e.g. information about which part of the app failed to provide the placeholder.Related: #285