Allow scoped calls to toHumanSize() #583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This PR adds support for the
scope
option to thetoHumanSize()
function.Right now, the function directly looks for a specific hardcoded scope that doesn't take into account if the user is passing a
scope
option. In our case, we wanted to have this kind of translations under ashared
scope, along the date formats and that kind of stuff, but usingtoHumanSize()
in it's current state makes it impossible.To fix it we calculate the scope before calling
t()
usinggetFullScope()
, passing the optionstoHumanSize()
got.Thanks!