Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump after the closing brackets (]]) on autocomplete #998

Merged
merged 5 commits into from
May 30, 2022

Conversation

Lauviah0622
Copy link
Contributor

@Lauviah0622 Lauviah0622 commented May 23, 2022

Reference to #962.

  • Add commit character | on link completion and section completion
  • Jump after the closing bracket on autocomplete except commit with # and |

Copy link
Collaborator

@riccardoferretti riccardoferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach!
Only comment, I would put the command code together in link-completion.ts: given that it's only meant to serve that functionality, I think it's a bit clearer that way.

Also, given that you had to work around the API, which means the purpose of the feature is not immediately clear by looking at the code, I would add a reference to what you are accomplishing (maybe even to the issue).

Thanks for figuring this out!

@Lauviah0622
Copy link
Contributor Author

Lauviah0622 commented May 24, 2022

Only comment, I would put the command code together in link-completion.ts: given that it's only meant to serve that functionality, I think it's a bit clearer that way.

No problem, I split out the file cause I'm not sure are there any other feature to use it in future. But it seems too single purposely so far, I agree with move in the link-completion.ts

Also, given that you had to work around the API, which means the purpose of the feature is not immediately clear by looking at the code, I would add a reference to what you are accomplishing (maybe even to the issue).

Thats a practical suggestion. I'll add some addition comment to referring to issue #962.

Copy link
Collaborator

@riccardoferretti riccardoferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@riccardoferretti riccardoferretti merged commit ddf7ddf into foambubble:master May 30, 2022
@riccardoferretti
Copy link
Collaborator

@allcontributors add @Lauviah0622 for code

@allcontributors
Copy link
Contributor

@riccardoferretti

I've put up a pull request to add @Lauviah0622! 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants