-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Jump after the closing brackets (]]) on autocomplete #998
Jump after the closing brackets (]]) on autocomplete #998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach!
Only comment, I would put the command code together in link-completion.ts
: given that it's only meant to serve that functionality, I think it's a bit clearer that way.
Also, given that you had to work around the API, which means the purpose of the feature is not immediately clear by looking at the code, I would add a reference to what you are accomplishing (maybe even to the issue).
Thanks for figuring this out!
No problem, I split out the file cause I'm not sure are there any other feature to use it in future. But it seems too single purposely so far, I agree with move in the
Thats a practical suggestion. I'll add some addition comment to referring to issue #962. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@allcontributors add @Lauviah0622 for code |
I've put up a pull request to add @Lauviah0622! 🎉 |
Reference to #962.
|
on link completion and section completion#
and|