MODINVOICE-545: Unpin jackson fixing Number Parse DoS (PRISMA-2023-0067) #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://folio-org.atlassian.net/browse/MODINVOICE-545 jackson-core package versions before 2.15.0 are vulnerable to Denial of Service (DoS): FasterXML/jackson-core#827 mod-invoice pins the jackson version to 2.13.4. This effectively downgrades the jackson version provided by RMB (domain-models-runtime, domain-models-api-interfaces) from 2.16.1 to 2.13.4. Fix: Unpin jackson.
julianladisch
requested review from
damien-git,
NikitaSedyx,
SerhiiNosko,
JavokhirAbdullayev and
Saba-Zedginidze-EPAM
SerhiiNosko
approved these changes
May 7, 2024
imerabishvili
approved these changes
May 7, 2024
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/MODINVOICE-545
jackson-core package versions before 2.15.0 are vulnerable to Denial of Service (DoS): FasterXML/jackson-core#827
mod-invoice pins the jackson version to 2.13.4. This effectively downgrades the jackson version provided by RMB (domain-models-runtime, domain-models-api-interfaces) from 2.16.1 to 2.13.4.
Fix: Unpin jackson.
Purpose
Fix vulnerability in jackson-core.
Approach
Unpin jackson.
Learning
Don't pin dependency versions provided by RMB or Spring.
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate action.