Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added check for lexicographical ordering of keys when decoding dictionaries in Bento.Parser #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ifoo
Copy link

@ifoo ifoo commented Sep 14, 2023

No description provided.

@github-actions github-actions bot added the test Changes or issues related to unit testing label Sep 14, 2023
@ifoo
Copy link
Author

ifoo commented Sep 14, 2023

I'm not sure if you want to add this, as it might break parsing of malformed dictionaries. On the one hand, dictionary keys that are not ordered are clearly defined as invalid in the spec. On the other hand, we might want the parser to be liberal. Best case would be the have an option (like strict: true) in the parsers function. Bento.decode already has opts, but Bento.Parser does not and I didn't want to break the API.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test Changes or issues related to unit testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant