Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Toast] Use the same different color on every inverted toast #197

Merged
merged 3 commits into from
Nov 19, 2018

Conversation

lubber-de
Copy link
Member

Description

This PR sets the color for all inverted toast variants to the same (default black) color instead of only for a few background colors. Keeps consistent track with #196

Screenshot

image

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 24, 2018
y0hami
y0hami previously approved these changes Oct 24, 2018
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick previously approved these changes Oct 24, 2018
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 24, 2018
prudho
prudho previously approved these changes Oct 29, 2018
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami added this to the 2.7.x milestone Oct 29, 2018
@lubber-de lubber-de self-assigned this Nov 8, 2018
@y0hami y0hami modified the milestones: 2.7.x, 2.7.0 Nov 15, 2018
@lubber-de lubber-de dismissed stale reviews from prudho, ColinFrick, and y0hami via ac59b79 November 16, 2018 14:20
@lubber-de lubber-de changed the base branch from beta to develop November 16, 2018 14:20
@lubber-de lubber-de added the state/awaiting-reviews Pull requests which are waiting for reviews label Nov 16, 2018
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Nov 19, 2018
@y0hami y0hami merged commit 58ac7e7 into fomantic:develop Nov 19, 2018
@lubber-de lubber-de deleted the inverted_toast_color branch November 20, 2018 08:56
This was referenced Dec 21, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants