-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Calendar] Add timegap setting to expand time selector #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudho
added
type/feat
Any feature requests or improvements
lang/javascript
Anything involving JavaScript
state/awaiting-reviews
Pull requests which are waiting for reviews
state/awaiting-docs
Pull requests which need doc changes/additions
labels
Oct 24, 2018
lubber-de
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ColinFrick
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
y0hami
removed
the
state/awaiting-reviews
Pull requests which are waiting for reviews
label
Oct 24, 2018
Planned for 2.7 |
This was referenced Dec 21, 2018
Merged
lubber-de
added
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
and removed
state/awaiting-docs
Pull requests which need doc changes/additions
labels
Jan 5, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
lang/javascript
Anything involving JavaScript
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
type/feat
Any feature requests or improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, i'm not the work's author, all kudos belong to @soar_lin (PR here). I just add some fixes for better reliability.
This PR allow different time gaps to be set, allowing different time selections (5 which is default, 10, 15, 20 and 30).
Screenshot (when possible)
10 minutes gap:
15 minutes gap: