-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(chore): color list for each component separately #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
Any feature requests or improvements
lang/css
Anything involving CSS
state/awaiting-reviews
Pull requests which are waiting for reviews
state/awaiting-docs
Pull requests which need doc changes/additions
tag/breaking-change
Any pull request which is waiting for a breaking change release
labels
Aug 26, 2021
Use this link for an easier review and ignore whitespace changes |
# Conflicts: # src/themes/default/globals/variation.variables
@exoego I merged the previous PR #,2106 so this one can be reviewed again, please. |
ColinFrick
approved these changes
Sep 23, 2021
lubber-de
removed
the
state/awaiting-reviews
Pull requests which are waiting for reviews
label
Sep 23, 2021
Doc hint added by fomantic/Fomantic-UI-Docs#377 |
lubber-de
added
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
and removed
state/awaiting-docs
Pull requests which need doc changes/additions
labels
Oct 1, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
lang/css
Anything involving CSS
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
tag/breaking-change
Any pull request which is waiting for a breaking change release
type/feat
Any feature requests or improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to define a color list for each component individually out of the central
colors.less
file.For example, now it is possible to have only red, blue and orange buttons, but only yellow labels and no colors for message at all. See example below.
All of this can be defined in the central
variation.variables
file as before (or in custom theme file)Before this change you were only able to reduce the whole color list by modifying the colors.less file and change the available colors for all components at once.
Testcase
Example config for the above mentioned different colors per component
Example to reduce the colors in all components inside the
variation.variables
file only without the need to modify thecolors.less
(unless one needs totally new color names of course)I also applied the same logic for states and consequences:
The default theme will still build all colors into every component as before.