Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Dropdown] Preselected values are ignored when data has individual value-name #285

Merged

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 4, 2018

Description

When a datastore has a different name for the value field, all probably preselected values will not be assigned initially to the dropdown. That's because it was always expecting its name being called value instead of respecting a probably changed name in settings.field.value.

Thanks @patilkiranm for the original PR

Testcase

Fixed Version

https://jsfiddle.net/pf2ae8cn/

Unfixed Version

https://jsfiddle.net/pf2ae8cn/1/

Closes

Semantic-Org/Semantic-UI#6682

@lubber-de lubber-de added the type/bug Any issue which is a bug or PR which fixes a bug label Dec 4, 2018
@lubber-de lubber-de added this to the 2.7.0 milestone Dec 4, 2018
@lubber-de lubber-de added lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Dec 4, 2018
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 501b61c into fomantic:develop Dec 5, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 5, 2018
@lubber-de lubber-de deleted the fix/6682/initial_selected_value_field branch December 5, 2018 11:20
This was referenced Dec 21, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants