[Form, Dropdown] Formvalidation broke when id has colon in it #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…find to support values containing :,=@. Broke otherwise. Also optimized form field fetching to reduce CPU time
lubber-de
added
type/bug
y0hami
removed
the
state/awaiting-reviews
This was referenced Dec 21, 2018
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is due to the use of jquery's
.filteror.finddom selector mechanismFUI already implemented an escaping function to mask special characters, but some of them were missing.
I also slightly optimized the
get.fieldfunction to not quering the dom twice. Might be just a few milliseconds, but every performance optimation counts 😆Testcase
Unfixed (open console, you'll see a jquery error when running the fiddle)
https://jsfiddle.net/h6sxdr1f/
Fixed (No console error and the value is set to the field as expected)
https://jsfiddle.net/h6sxdr1f/1/
Closes
Semantic-Org/Semantic-UI#6701