Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Visibility] rename placeholder class #297

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Conversation

y0hami
Copy link
Member

@y0hami y0hami commented Dec 11, 2018

Description

Rename the placeholder class to constraint to stop the conflict with the placeholder component

Testcase

Broken: https://jsfiddle.net/djpw7ket/
Fixed: https://jsfiddle.net/yge5fm2c/

Screenshot (when possible)

Broken:
image

Fixed:
image

Closes

#296

Rename the placeholder class to constraint to stop the
conflict with the placeholder component

Closes #296
@y0hami y0hami added lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build 🐛 bugfix labels Dec 11, 2018
@y0hami y0hami added this to the 2.7.0 milestone Dec 11, 2018
@y0hami y0hami self-assigned this Dec 11, 2018
@y0hami y0hami removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 11, 2018
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 11, 2018
@y0hami y0hami merged commit fba5c8c into develop Dec 11, 2018
@y0hami y0hami deleted the fix/visibility-placeholder branch December 11, 2018 15:18
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants