Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show StockArticle price details to user #184

Merged
merged 9 commits into from
Oct 8, 2013

Conversation

JuliusR
Copy link
Contributor

@JuliusR JuliusR commented Oct 3, 2013

  • Update en and de locales

Currently it is quite hard to find out e.g. the deposit of a StockArticle. This shall

  • add the article price tooltip to the StockTaking form
  • move the StockArticle#history to StockArticle#show where additional information are presented (I avoided to add the tooltip to the long StockArticle#index table. Let us care for the page loading speed.)

I am not sure how to handle the translations. Also see my questions in foodcoops#137. Some I could delete or rename on my own. Does this help? Now I plan to provide en and de. Would that be enough?

animation: false,
html: true,
placement: 'left'
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs update as in 1fed983 after #149 is merged. Alternatively, the function including the fix could be moved to all views.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done so in b8ff431

@JuliusR
Copy link
Contributor Author

JuliusR commented Oct 5, 2013

Attention when merging: Some locales were moved (e. g. from stockit.history. to stockit.show.).

@JuliusR JuliusR mentioned this pull request Oct 5, 2013
5 tasks
wvengen added a commit that referenced this pull request Oct 8, 2013
@wvengen wvengen merged commit ac3e5cd into foodcoops:master Oct 8, 2013
@JuliusR JuliusR deleted the article-price-tooltip branch October 8, 2013 16:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants