Allow selecting struct columns without breaking up the struct #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature allows selecting structs without breaking them up
|
Thanks for the contribution! Before we can merge this, we need @Learath2 to sign the Salesforce Inc. Contributor License Agreement. |
atulkc
requested changes
May 7, 2024
| @@ -1096,6 +1107,22 @@ var _ = Describe("Marshaller", func() { | |||
| Expect(str).To(Equal("Id,Name__c,NonNestedStruct__r.Name,NonNestedStruct__r.SomeValue__c")) | |||
| }) | |||
| }) | |||
|
|
|||
| Context("when nested struct with soql fields is selected opaquely", func() { | |||
There was a problem hiding this comment.
Can you add a test that verifies the entire SOQL generation? Basically add a Context to Describe("Marshal")
|
I did sign the CLA and if I click the link again it says you have already signed the CLA. It seems broken somehow |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows selecting structs without breaking them up. It's useful for types like
time.Time, where having it as aselectColumngenerates nothing in the marshalled select clause.