fix(balances): return empty list balances response instead of nil

[laouji]

balance endpoint now returns when there's no balance data for the account

HTTP/1.1 200 OK
Content-Type: application/json
Date: Mon, 27 Jan 2025 13:00:07 GMT
Content-Length: 53

{"cursor":{"pageSize":15,"hasMore":false,"data":[]}}

[coderabbitai]

Walkthrough

The pull request introduces a minor optimization in the toBalancesModels function within the internal/storage/balances.go file, improving slice allocation efficiency. Additionally, a new test case has been added to the TestBalancesUpsert function in balances_test.go to validate the behavior of the BalancesList method when no balances are available for a given account ID.

Changes

File	Change Summary
internal/storage/balances.go	Optimized slice initialization using make([]models.Balance, 0, len(from)) to pre-allocate memory
internal/storage/balances_test.go	Added "no balances available" test case for BalancesList method to verify empty result handling

Poem

🐰 Slice of memory, neat and tight
Pre-allocated with rabbit's might
No balances? No need to fret
Our test will catch each small offset
Performance dancing, code so bright! 🚀

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.05%. Comparing base (d6830f1) to head (10ac6ed).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   73.05%   73.05%           
=======================================
  Files         537      537           
  Lines       27113    27115    +2     
=======================================
+ Hits        19808    19810    +2     
  Misses       6238     6238           
  Partials     1067     1067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

internal/storage/balances_test.go (1)

264-281: LGTM! Consider adding pagination metadata assertions.

The test case effectively validates the empty list behavior. For completeness, consider adding assertions for pagination metadata:

 		cursor, err := store.BalancesList(ctx, q)
 		require.NoError(t, err)
 		require.Len(t, cursor.Data, 0)
 		require.Equal(t, expectedBalances, cursor.Data)
+		require.False(t, cursor.HasMore)
+		require.Empty(t, cursor.Next)
+		require.Empty(t, cursor.Previous)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74373dd and 10ac6ed.

📒 Files selected for processing (2)

• internal/storage/balances.go (1 hunks)
• internal/storage/balances_test.go (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• internal/storage/balances.go