Skip to content

Don't require name from OpenStreetMap when name is blank #242

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CaptainGlac1er
Copy link

@CaptainGlac1er CaptainGlac1er commented Apr 12, 2025

Closes: #241

Description

Added name as an optional field when OpenStreetMap returns an empty string for name

Use this section to provide a summary description of the changes you've made

Why have you chosen this solution?

OpenStreetMap returns an empty string for name.

Potential better solution is to check source, then check for the mandatory fields only. Right now address2 is optional but that is part of manual input.

Breaking Changes / Backwards Compatibility

Not breaking change

Dependencies

N/A

How has this PR been tested?

Added unit test to cover this scenario

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@CaptainGlac1er CaptainGlac1er changed the title Don't require name from OpenStreetMap when name is blank Fixes #241 Don't require name from OpenStreetMap when name is blank Apr 12, 2025
@CaptainGlac1er CaptainGlac1er changed the title Fixes #241 Don't require name from OpenStreetMap when name is blank Closes: #241 Don't require name from OpenStreetMap when name is blank Apr 12, 2025
@CaptainGlac1er CaptainGlac1er changed the title Closes: #241 Don't require name from OpenStreetMap when name is blank Don't require name from OpenStreetMap when name is blank Apr 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If a valid Address returned by OpenStreetMap has an empty name it does not pass required validation
1 participant