Don't require name from OpenStreetMap when name is blank #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #241
Description
Added
name
as an optional field when OpenStreetMap returns an empty string for nameUse this section to provide a summary description of the changes you've made
Why have you chosen this solution?
OpenStreetMap returns an empty string for name.
Potential better solution is to check source, then check for the mandatory fields only. Right now
address2
is optional but that is part of manual input.Breaking Changes / Backwards Compatibility
Not breaking change
Dependencies
N/A
How has this PR been tested?
Added unit test to cover this scenario
Checklist: