Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix Vue warn in PhantomJS browser #23

Closed
wants to merge 1 commit into from
Closed

fix Vue warn in PhantomJS browser #23

wants to merge 1 commit into from

Conversation

klarkc
Copy link
Contributor

@klarkc klarkc commented Dec 14, 2017

fix ERROR: '[Vue warn]: Duplicate keys detected: 'formly_{field.key}'. This may cause an update error. in PhantomJS browser

@matt-sanders matt-sanders mentioned this pull request Dec 17, 2017
Merged
matt-sanders added a commit that referenced this pull request Dec 17, 2017
@matt-sanders
Merge pull request #24 from formly-js/incorrect-keys
ae6b726 
fixing incorrect key error from #23
@matt-sanders
Copy link
Contributor

@klarkc thanks heaps for the PR! I've instead chosen to make a new PR which doesn't have the modified package.json file, includes a unit test, and favours ${field.key} over '' + field.key. Just to keep everything up to spec :) You can check out that PR here #24

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klarkc @matt-sanders