Enable enclave_loader() fallback to libsgx_enclave_common.so.1
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 6, 2023
432: Enable `enclave_loader()` fallback to libsgx_enclave_common.so.1 r=mzohreva a=raoulstrackx The `aesmd` service depends on a `dcap_quoteprov.so` library (the DCAP provider) to aid in DCAP attestations. For it to work correctly, it may need to (recursively) request a DCAP attestation itself. For that a `dcap-ql::enclave_loader` call is required. Unfortunately, when this happens as part of the `aesmd` service, `Dl::this()` returns `/opt/intel/sgx-aesm-service/aesm/aesm_service`. This leads to an error as the expected symbols can't be located. This PR adds a fallback to the `libsgx_enclave_common.so.1` library (or `sgx_enclave_common.dll` on windows). Co-authored-by: Raoul Strackx <raoul.strackx@fortanix.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded:
|
bors bot
added a commit
that referenced
this pull request
Feb 9, 2023
434: Enable `enclave_loader()` fallback to `libsgx_enclave_common.so.1` r=mzohreva a=raoulstrackx The aesmd service depends on a dcap_quoteprov.so library (the DCAP provider) to aid in DCAP attestations. For it to work correctly, it may need to (recursively) request a DCAP attestation itself. For that a `dcap-ql::enclave_loader` call is required. Unfortunately, when this happens as part of the aesmd service, `Dl::this()` returns `/opt/intel/sgx-aesm-service/aesm/aesm_service`. This leads to an error as the expected symbols can't be located. This PR adds a fallback to the `libsgx_enclave_common.so.1` library (or `sgx_enclave_common.dll` on windows). This commit has been merged already on a different branch as part of #432 Co-authored-by: Raoul Strackx <raoul.strackx@fortanix.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aesmdservice depends on adcap_quoteprov.solibrary (the DCAP provider) to aid in DCAP attestations. For it to work correctly, it may need to (recursively) request a DCAP attestation itself. For that adcap-ql::enclave_loadercall is required. Unfortunately, when this happens as part of theaesmdservice,Dl::this()returns/opt/intel/sgx-aesm-service/aesm/aesm_service. This leads to an error as the expected symbols can't be located. This PR adds a fallback to thelibsgx_enclave_common.so.1library (orsgx_enclave_common.dllon windows).