-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding test and fix for ^uint64(0) -> float #8
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 33 33
=========================================
Hits 33 33 ☔ View full report in Codecov by Sentry. |
@ccoVeille are you aware of any bug with this minimal/generic version? if so I'd love to know. If not I might make this 1.0.0 Thanks! |
I talked about on Slack, but for anyone interested |
yes that's not a bug that's indeed loosing .1 of 1.1 thus an error. if it's ok to truncate or round that's why we have Truncate and Round, but Convert alone shouldn't silently remove precision (and that's exactly what the new test verifies) |
Also reduce API surface. removed Negative() and SameSign()