This repository has been archived by the owner on Sep 19, 2022. It is now read-only.
Named routes with their class route definition to easy the use of $app->urlFor() #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can i kiss you? :D |
|
I like this. Can someone add some unit tests for it? I'll do it when I get a chance but I know I'll likely be too busy until at least Wednesday. |
Added unit tests for named routes
yaworsw
added a commit
that referenced
this pull request
Nov 8, 2013
Named routes with their class route definition to easy the use of $app->urlFor()
|
Hey guys, I've been added to the contributor list for slim controller. I merged both of @falmp's pull requests and bumped the version to 0.3.0. |
|
That's good news! Thank you for the merges, I'll keep them coming whenever I see something worth it. |
|
And I'll write the unit tests lol |
|
Heheh indeed I'm still not too used to code the tests, but I'll do my best next time. ;) |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can still set custom names with the $app->addControllerRoute()->name() as suggested on issue #6.