fix issue #375 : a small qol change #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perazz
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks @AnonMiraj, looks good as far as I'm concerned, from what I see the edge cases are covered OK. I like the idea of running tests in the same order as the manifest.
|
@henilp105 |
henilp105
approved these changes
Mar 23, 2024
|
Thanks @AnonMiraj @perazz , I will be merging in a few hours if there are no more comments. |
|
Merging! |
This was referenced Apr 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this old issue #375 and implemented this small quality of life change.
Now, the tests will run in the order specified in the arguments of the command. It is a small change, so it won't have consequences on other parts of the code base.