-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Some cleanups and minor fixes #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zoziha - these changes all look fine to me. A couple of minor comments:
- Are you able to fix this line in
new-test
as well:fpm/test/new_test/new_test.f90
Line 156 in cd8b5cc
rm_command = 'rmdir ' // dirs_to_be_removed // ' /s /q' - In
backend_output
, perhaps we should just declareoverall_progress
with length7
and remove the(:7)
indexing?
Thanks for reviewing, @LKedward .
Sorry I didn't see this line of code before, I'll update my commit to fix it.
Nice suggestion ~ |
cd8b5cc
to
88834b4
Compare
The wildcard command line usage on Windows to delete folders does not take effect in the actual test.
88834b4
to
5253412
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Thanks @zoziha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing. Looks good to me.
Description
While using
fpm
and reading thefpm
source code, I have found some small areas for improvement, as they tend to be small and have little impact on the overall functionality offpm
, and it doesn't seem worth it to list them as a single PR.Updates
The work this PR does:
fnv_1a
reference;number_of_rows
, remove unnecessary character reading;mkdir
andos_delete_dir
, the output format of which is somewhat complicated, and the current modification is unified with the following style:fpm/src/fpm_filesystem.F90
Line 906 in aec789f
==
,/=
, etc. are more intuitive and modern than.eq.
,.ne.
;new_test
test, the wildcard command line used in CMD shell on Windows did not actually take effect, which was corrected;📢 PS. I made a single commit record for each fix, it would be simple enough to review them in turn.