Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

properly document FPM_CXX, FPM_CXXFLAGS and options #788

Merged
merged 3 commits into from
Oct 29, 2022

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Oct 29, 2022

fpm doesn't document C++ compiler / flags neither in README.md neither in fpm help output.

the following PR adds it.

@awvwgk awvwgk added the documentation Improvements or additions to documentation label Oct 29, 2022
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. Looks good to me.

@semarie
Copy link
Contributor Author

semarie commented Oct 29, 2022

I am unsure about the reason macos failed. it seems to have failed in help-test (when runned with bootstrap version)

@semarie
Copy link
Contributor Author

semarie commented Oct 29, 2022

Finally found it:

<INFO>CMD=build/gfortran_2A42023B310FA28D/test//../app/fpm help new        >fpm_scratch_help.txt EXITSTAT=0 CMDSTA
T=0 MESSAGE=

*slurp* empty file fpm_scratch_help.txt
Program received signal SIGSEGV: Segmentation fault - invalid memory reference.
 <ERROR>*swallow* failed to load file fpm_scratch_help.txt

@LKedward
Copy link
Member

Apologies @semarie - the CI failure is because macos-latest has changed from macos-11 to macos-12. To get this merged, I've updated your PR to pin the CI runner to macos-11 for now. We will need to fix this CI problem separately.

@LKedward LKedward merged commit e3487c5 into fortran-lang:main Oct 29, 2022
@LKedward
Copy link
Member

Many thanks @semarie! I've now merged this, I'll open a separate issue for the MacOS-12 failure.

@semarie
Copy link
Contributor Author

semarie commented Oct 29, 2022

thanks for the merge

@semarie semarie deleted the cxx-doc branch October 29, 2022 09:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants