Skip to content

fix: multiple minor fixes #29

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Oct 12, 2023
Merged

fix: multiple minor fixes #29

merged 4 commits into from
Oct 12, 2023

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Jul 25, 2023

  • set SETVARS_COMPLETED and CXX after installing/activating Intel toolchain on Windows
    • documented windows, linux/mac — also set in export_intel_vars but doesn't run if cache hit on windows
  • don't unset local _KEY in install_intel_apt function
  • remove ifx 2021.3 + ubuntu from compat table (fails to install)
  • add intel and intel-classic + ubuntu-20.04 jobs to test matrix
    • same as on ubuntu-22.04

…n, don't unset local variable in install_intel_apt bash function, test intel and intel-classic on ubuntu-20.04
@wpbonelli
Copy link
Contributor Author

@awvwgk I think this will fix intel support on ubuntu 20.04.

Happy to do maintenance here if your bandwidth is low but I don't have merge permission. Hoping to retire https://github.com/modflowpy/install-intelfortran-action and https://github.com/modflowpy/install-gfortran-action soon in favor of this action

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing, looks good to me.

@awvwgk awvwgk merged commit 2bc384c into fortran-lang:main Oct 12, 2023
@wpbonelli wpbonelli deleted the develop branch October 12, 2023 13:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants