Probability Distribution and Statistical Functions -- PRNG Module #271
Conversation
changed the object name from stdlib_stats_distribution_implementation.o to stdlib_stats_distribution_imp.o
Jim-215-Fisher
changed the title
|
Thank you @Jim-215-Fisher for this PR. Is it ready for review? |
Yes. I think it is ready. |
There was a problem hiding this comment.
Thanks @Jim-215-Fisher for this PR. Here are some first comments.
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
|
Thank you @Jim-215-Fisher for this PR. I have no additional comments for now. |
|
I agree. +1 to merge and move to the next pull request. |
There was a problem hiding this comment.
@milancurcic Can you merge it if you are ok with it,please?
|
Thank you all, I will review this weekend and merge. |
There was a problem hiding this comment.
Thank you @Jim-215-Fisher and reviewers. I left two more suggestions, feel free to apply them or not.
| data int01, int02, int03/-7046029254386353131_int64, & | ||
| -4658895280553007687_int64, & | ||
| -7723592293110705685_int64/ |
There was a problem hiding this comment.
These could be rewritten as integer(int64), parameter, which IMO would be cleaner, and I think just as efficient as data statement.
Co-authored-by: Milan Curcic <caomaco@gmail.com>
I would recommend squashing commits, not to polute the history with the numerous commits. |
|
@Jim-215-Fisher Please let us know if this is good to go, and we'll squash and merge. |
OK. It is ready to go. |
This is the second round of probability distribution and statistical functions, continuing from #240. Since the whole modular structure has been changed, each distribution will have its own PR.
This PR contains random number generators used for probability distributions. Files uploaded are:
src/stdlib_stats_distribtuion.PRNG.fypp
src/CmakeLists.txt
src/Makefile.manual
src/tests/test_distribution_PRNG.f90
src/tests/CmakeLists.txt
src/tests/Makefile.manual
doc/specs/stdlib_stats_distribution_PRNG.md
doc/specs/index.md