Skip to content

Fix linking issue with shared libraries #642

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Mar 24, 2022

Closes #641

@awvwgk awvwgk added bug Something isn't working build: cmake Issue with stdlib's CMake build files labels Mar 24, 2022
@awvwgk awvwgk requested a review from a team March 26, 2022 13:14
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (AFAIK)

@awvwgk
Copy link
Member Author

awvwgk commented Mar 27, 2022

Might be useful to have a bug fix release 0.2.1 later to incorporate this and other build system fixes.

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, let's merge it.

@milancurcic milancurcic merged commit 8eaa778 into fortran-lang:master Mar 29, 2022
@awvwgk awvwgk deleted the cmake branch March 29, 2022 19:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working build: cmake Issue with stdlib's CMake build files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash test fails when stdlib is a shared library
3 participants