Skip to content

Improve doc + examples of stdlib_stats_distribution_normal #718

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Jun 15, 2023

Conversation

HugoMVale
Copy link
Contributor

As a complement to PR #679, I've made a couple of improvements on the doc and related examples.

  • Improve readability of specs
  • Add examples with sigma<=0 to show expected behavior (NaN, not error).
  • Add examples with calls inside do concurrent to show it is (now) possible.
  • Rename example_norm_cdf.f90 to example_normal_cdf.f90 for consistency with other files.

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HugoMVale
Copy link
Contributor Author

Based on the question from @jvdp1 on #717, I've explicitly added the NaN behavior to the specs.

@HugoMVale
Copy link
Contributor Author

After a number of tweaks, I guess this is now "finished", i.e. I've completed what I had planned to do.

@jvdp1
Copy link
Member

jvdp1 commented Jun 15, 2023

Thank you for your improvements. I'll merge it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants