Skip to content

Fix ci for windows and Intel ifx (#7) #752

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Dec 26, 2023

Conversation

jvdp1
Copy link
Member

@jvdp1 jvdp1 commented Dec 24, 2023

Fixes multiple issues with CI (Ubuntu + Intel and Windows)

Changes:

  • Windows: GCC 13
  • Ubuntu-latest: Intel LLVM (instead of Classic)
  • Relax test in test_rawmoment due to change from Intel Classic to Intel LLVM

Note: CI for Windows works, but could be most likely improved (but how?)

Changes:

* Windows: GCC 13
* Ubuntu-latest: Intel LLVM (instead of Classic)
* Relax test in test_rawmoment due to change from Intel Classic to Intel LLVM
@jvdp1 jvdp1 requested review from milancurcic and awvwgk December 24, 2023 23:20
@jvdp1
Copy link
Member Author

jvdp1 commented Dec 24, 2023

This PR should be merged for enabling (at least) #747 #743

Most likely related issue: #750

@jvdp1 jvdp1 added the reviewers needed This patch requires extra eyes label Dec 25, 2023
@jvdp1 jvdp1 requested review from gnikit and a team December 25, 2023 15:34
Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jvdp1 , Looks good to me. I have suggested some minor changes. we had been facing similar issue at fpm fortran-lang/fpm#976 .

@jvdp1 jvdp1 removed the reviewers needed This patch requires extra eyes label Dec 26, 2023
@jvdp1
Copy link
Member Author

jvdp1 commented Dec 26, 2023

There are 2 approvals. I will merge it to allow others to be merged too.

@jvdp1 jvdp1 merged commit 77c10e1 into fortran-lang:master Dec 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants