Skip to content

least squares: relax test tolerance #809

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2024
Merged

least squares: relax test tolerance #809

merged 1 commit into from
May 11, 2024

Conversation

perazz
Copy link
Member

@perazz perazz commented May 9, 2024

Problem:
1.0e-6 is too tight a tolerance for least squares on some systems (1.0e-6 << sqrt(epsilon(0.0)))

Example: failed CI job
https://github.com/fortran-lang/stdlib/actions/runs/9015259889/job/24769521465

Solution:
relax tolerance to 1.0e-4

cc: @jvdp1 @jalvesz

@perazz perazz mentioned this pull request May 9, 2024
Merged
7 tasks
jvdp1
jvdp1 approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @perazz

I will merge it.

@jvdp1 jvdp1 merged commit 60ce18f into fortran-lang:master May 11, 2024
17 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jvdp1 jvdp1 jvdp1 approved these changes

@gareth-nx gareth-nx gareth-nx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perazz @jvdp1 @gareth-nx