-
Notifications
You must be signed in to change notification settings - Fork 191
promote ascii functions to elemental #886
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I remember that some older versions of gfortran had issues with elemental
functions and character
. However, that seems not an issue here as all tests pass with all supported gfortran versions. LGTM, thank you @jalvesz
Do you remember if it was a compile-time problem or a run-time problem? maybe it would be better to add array-like tests also ? I don't recall running into such problems. |
I can't find a link right now in my bugzilla - I suggest we wait for another while, and if no further comments arise, this PR can be merged imho. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my side I think it could be merged. The fails in the macOS CI are due to an update in github, which can be fixed in another PR.
|
Merging now. |
Promote ascii functions from pure to elemental for potentially better optimization and ease use for array expressions manipulation.