chore: proactively set stripe ids

[spence-s]

• Creates and Sets and stores the stripe id for the customer regardless of whether they checkout or not.
• For some reason web tests would not pass for me.

  Uncaught exception in test/web/auth.js

  Error:
  Something went wrong installing the "sharp" module

  Module did not self-register: '/Users/spencer/Projects/forwardemail.net/node_modules/sharp/build/Release/sharp-darwin-x64.node'.

  Possible solutions:
  - Install with verbose logging and look for errors: "npm install --ignore-scripts=false --foreground-scripts --verbose sharp"
  - Install for the current darwin-x64 runtime: "npm install --platform=darwin --arch=x64 sharp"
  - Consult the installation documentation: https://sharp.pixelplumbing.com/install

  › - Consult the installation documentation: https://sharp.pixelplumbing.com/install
  › Object.<anonymous> (node_modules/sharp/lib/sharp.js:34:9)
  › Module.replacementCompile (node_modules/append-transform/index.js:60:13)
  › node_modules/append-transform/index.js:64:4
  › Object.<anonymous> (node_modules/append-transform/index.js:64:4)
  › Object.<anonymous> (node_modules/sharp/lib/constructor.js:8:1)
  › Module.replacementCompile (node_modules/append-transform/index.js:60:13)
  › node_modules/append-transform/index.js:64:4

(node:88019) [DEP0128] DeprecationWarning: Invalid 'main' field in '/Users/spencer/Projects/forwardemail.net/node_modules/factory-girl/package.json' of './src/index'. Please either fix that or report it to the module author
(Use `node --trace-deprecation ...` to show where the warning was created)
  ✖ test/web/auth.js exited with a non-zero exit code: 1
  ─

  `--fail-fast` is on. 4 test files were skipped.

  5 tests passed
  1 uncaught exception

[spence-s]

Seems as though the same test problems are happening here in CI

[titanism]

• Drop yarn and remove yarn.lock if necessary. There should already be a .npmrc with package-lock=false in the repo too, and yarn.lock is already in the .gitignore (ref https://github.com/forwardemail/forwardemail.net/blob/master/.gitignore#L19 and https://github.com/forwardemail/forwardemail.net/blob/master/.npmrc)
• Revert changes to husky hooks
• Rewrite the code block for setting stripe ID as follows:

//
// create and validate stripe customer here
// (ensure valid customer before webhooks hit)
//
try {
  const customer = isSANB(ctx.state.user[config.userFields.stripeCustomerID]) ?
    await stripe.customers.retrieve(ctx.state.user[config.userFields.stripeCustomerID]) :
    await stripe.customers.create({ email: ctx.state.user.email });

  if (customer.deleted) {
    ctx.logger.warn('Stripe customer previously deleted', { customer });
    customer = await stripe.customers.create({ email: ctx.state.user.email });
  }

  ctx.state.user[config.userFields.stripeCustomerID] = customer.id;
  await ctx.state.user.save();
} catch (err) {
  ctx.logger.fatal(err);
  // email admins here
  try {
    await emailHelper({
      template: 'alert',
      message: {
        to: config.email.message.from,
        subject: `Error creating Stripe customer for ${ctx.state.user.email}`
      },
      locals: { message: err.message }
    });
  } catch (err) {
    ctx.logger.fatal(err);
  }

  throw ctx.translateError('UNKNOWN_ERROR');
}

[spence-s]

Made all the requested changes - still seeing the same test issues, even after removing everything and reinstalling with NPM.